Adapt client libraries and clients to voms aa #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The depth of some fields was not correct for the response obtained through the REST API, which is the first one tried and the only one that will survive in the future with VOMS-AA. In addition, VOMS-AA returns a numeric code for an error condition, not a string like VOMS server.
* Always process the errors, not only in case an AC has been returned * For certain errors (user doesn't exist, is suspended, is inactive) do not try the legacy endpoint, which doesn't even exist for VOMS AA * Leave some commented-out debug messages, to be possibly included in the output in debug mode (requires some work to propagate the debug flag)
Contrary to the VOMS server, VOMS-AA expects that the fqans query parameter includes also the FQANs specified with the --order command line argument of voms-proxy-init. We keep the order query parameter, which is instead expected by the VOMS server.
And avoid the use of std::next, which is C++11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124