Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: corrected base uri in common.rst and phone numbers examples in IT, EN #195

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: corrected base uri in common.rst and phone numbers examples in IT, EN #195

merged 3 commits into from
Oct 31, 2023

Conversation

rglauco
Copy link
Contributor

@rglauco rglauco commented Oct 16, 2023

Title

Content

Review

  • Ensure your files are written following RST specs (not MD!)
  • Italian version
  • English version
  • Example files
  • Ask for review

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
spid-cie-oidc-docs ❌ Failed (Inspect) Oct 17, 2023 6:08am

@rglauco rglauco changed the title fix: corrected phone numbers examples in IT, EN fix: corrected base uri in common.rst and phone numbers examples in IT, EN Oct 17, 2023
@peppelinux
Copy link
Member

@rglauco do you confirm that you have already get a positive feedback from AgID in relation to this proposed change?

@damikael ^

@rglauco
Copy link
Contributor Author

rglauco commented Oct 21, 2023

@rglauco do you confirm that you have already get a positive feedback from AgID in relation to this proposed change?

@damikael ^

Yes, i've talked to them and they confirm the typo. I've sent them an email with the typos found in the pdf.

There's a little discrepancy regarding "gender" claim:
PDF AgID pag. 4: M/F
docs.italia.it: male/female

@peppelinux peppelinux merged commit 04016c8 into italia:versione-corrente Oct 31, 2023
3 of 4 checks passed
damikael
damikael reviewed Oct 31, 2023
View reviewed changes
docs/it/attributi_utente.rst
@@ -203,15 +203,15 @@ La seguente tabella riporta l'elenco degli attributi utente supportati da SPID e
* - **phone_number** |br| Categoria: extra anagrafica
- Numero di telefono mobile. String. Stringa numerica senza spazi intermedi |br|
Esempio: |br|
``"phone_number":"VATIT-12345678901"``
``"phone_number":"12345678901"``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+3912345678901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damikael damikael damikael left review comments

@fmarino-ipzs fmarino-ipzs fmarino-ipzs approved these changes

@peppelinux peppelinux peppelinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rglauco @peppelinux @damikael @fmarino-ipzs