Errors that might occur during the presentation #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
requested review from
fmarino-ipzs,
balanza,
grausof,
giadas and
asharif1990
This was referenced Mar 2, 2024
Merged
|
See also |
giadas
reviewed
Mar 3, 2024
giadas
reviewed
Mar 3, 2024
Co-authored-by: Giada Sciarretta <[email protected]>
fmarino-ipzs
approved these changes
Mar 4, 2024
peppelinux
pushed a commit
that referenced
this pull request
Mar 5, 2024
* fix!: alignments according to breaking changes introduced by openid4vci I-D * RP WTE in PE and Entity Configuration base * fix: RP presentation with client_id_scheme and request_uri_method within the qrcode/redirect url * fix: RP presentation with client_id_scheme and request_uri_method using post * fix: RP presentation defintiion with WTE with exp and iat as constraints * RP Giada's revision * RP state definition * Apply suggestions from code review Co-authored-by: Giada Sciarretta <[email protected]> * RP seq diag svg aligned * Errors that might occur during the presentation (#226) * RP errors * Apply suggestions from code review Co-authored-by: Giada Sciarretta <[email protected]> * fix: figure visualization issue * fix: editorial --------- Co-authored-by: Giada Sciarretta <[email protected]> Co-authored-by: fmarino-ipzs <[email protected]> * fix: renamed Wallet Trust Evidence in Wallet Attestation * Apply suggestions from code review Co-authored-by: Francesco Grauso <[email protected]> --------- Co-authored-by: Giada Sciarretta <[email protected]> Co-authored-by: fmarino-ipzs <[email protected]> Co-authored-by: Francesco Grauso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR aims to close #224
since we still don't have the required details in the openid4vp specs, I propose a relaxed language and generic error identifiers.
I hope that this little step might help the discussion within the openid working group.