fix(software): properly remove associations on DELETE (#140)

italia · Sep 10, 2022 · c73780d · c73780d
1 parent c664f42
commit c73780d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/internal/handlers/software.go b/internal/handlers/software.go
@@ -179,9 +179,7 @@ func (p *Software) PatchSoftware(ctx *fiber.Ctx) error {
 
 // DeleteSoftware deletes the software with the given ID.
 func (p *Software) DeleteSoftware(ctx *fiber.Ctx) error {
-	var software models.Software
-
-	if err := p.db.Delete(&software, "id = ?", ctx.Params("id")).Error; err != nil {
+	if err := p.db.Select("Aliases").Delete(&models.Software{ID: ctx.Params("id")}).Error; err != nil {
 		if errors.Is(err, gorm.ErrRecordNotFound) {
 			return common.Error(fiber.StatusNotFound, "can't delete Software", "Software was not found")
 		}

diff --git a/main_test.go b/main_test.go
@@ -1631,6 +1631,7 @@ func TestSoftwareEndpoints(t *testing.T) {
 			expectedBody:        "",
 			expectedContentType: "application/json",
 		},
+		// TODO: check there are no dangling software_urls
 
 		// GET /software/:id/logs
 		{