Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: header improvements #1125

Merged
merged 22 commits into from
Dec 2, 2024
Merged

feat: header improvements #1125

merged 22 commits into from
Dec 2, 2024

Conversation

Virtute90
Copy link
Collaborator

Fixes #1099

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Corretto stile per lo slim header e risolta problematica con versione mobile

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Dec 2, 2024 4:43pm

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 99.21875% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (f062f26) to head (3e84524).

Files with missing lines Patch % Lines
stories/Components/Header/SlimHeader.stories.tsx 99.20% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         357      357           
  Lines       25303    25304    +1     
  Branches     1695     1696    +1     
=======================================
+ Hits        24627    24628    +1     
  Misses        674      674           
  Partials        2        2           
Flag Coverage Δ
unittests 97.32% <99.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi
Copy link
Member

astagi commented Nov 21, 2024

Grazie @Virtute90 facciamo review ☺️

@astagi astagi requested review from astagi and Fupete November 21, 2024 17:00
@astagi astagi linked an issue Nov 29, 2024 that may be closed by this pull request
1 task
@astagi astagi changed the title fix: slim header style feat: header improvements Dec 1, 2024
@astagi astagi marked this pull request as draft December 1, 2024 16:51
@astagi astagi marked this pull request as ready for review December 2, 2024 15:49
@astagi astagi merged commit f7e2a76 into italia:main Dec 2, 2024
5 checks passed
@Virtute90 Virtute90 deleted the fix/header branch December 2, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants