Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use navscroll #1019

Closed
wants to merge 1 commit into from
Closed

Conversation

astagi
Copy link
Member

@astagi astagi commented Feb 7, 2024

Fixes #1017

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Feb 7, 2024 3:34pm

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27016b7) 92.17% compared to head (0147ec6) 92.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   92.17%   92.13%   -0.04%     
==========================================
  Files         282      282              
  Lines        2825     2824       -1     
  Branches      720      720              
==========================================
- Hits         2604     2602       -2     
- Misses        217      218       +1     
  Partials        4        4              
Flag Coverage Δ
unittests 92.13% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi
Copy link
Member Author

astagi commented Feb 7, 2024

@Virtute90 this PR is wrong, removing this dependency causes errors for NavScroll. @sabato-galasso suggests to replace this package with https://github.com/fisshy/react-scroll

@astagi astagi closed this Feb 28, 2024
@astagi astagi deleted the deps/remove-react-use-navscroll branch March 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ERESOLVE overriding peer dependency
1 participant