[17.0] [MIG] base_api, openapi #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💶 decreased due to creation of base_api 📖 description of error by skipping step about 'server_wide_modules' 🌈 refactoring due to creation of 'base_api' module closes #64
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working if isinstance(v, collections.Mapping):
It should be + fields = [ + 'company_id/id', + 'company_id/name' + ] instead of - fields = [ - company_id, - company_id/name - ]
new support address 👉 
close #227 > Made via .github/workflows/DINAR-PORT.yml
close #403 > Made via .github/workflows/DINAR-PORT.yml
close #432 > Made via .github/workflows/DINAR-PORT.yml
also, add parameter `field` explicitly
previous commits history: https://github.com/itpp-labs/sync-addons/commits/13.0/openapi > Made via .github/workflows/DINAR-PORT.yml
close #224 > Made via .github/workflows/DINAR-PORT.yml
> Made via .github/workflows/DINAR-PORT.yml
to fix this error: ``` ValueError: Field model_id of model openapi.access is defined as ondelete='restrict' while having ir.model as comodel, the 'restrict' mode is not supported for this type of field as comodel. ```
we don't need to use the internal mechanism of CORS handling because in any way we have to use additional Nginx settings and it causes an error like: "The 'Access-Control-Allow-Origin' header contains multiple values"
for a swagger, clarification is needed about which type of content the method consumes
in docs and fix formatting in the changelog
close #410 > Made via .github/workflows/DINAR-PORT.yml
close #412
close #430 > Made via .github/workflows/DINAR-PORT.yml
Thanks to new feature in v16, the module is not needed to be too hacky anymore See https://github.com/odoo/odoo/blob/48e410477d7f48ff253029301f470e9612f25d59/odoo/addons/test_http/controllers.py#L77-L83
em230418
reviewed
Oct 15, 2024
openapi/controllers/pinguin.py
Outdated
Comment on lines
320
to
324
| for k in ["form", "files"]: | ||
| try: | ||
| del log_data["request_data"][k] | ||
| except KeyError: | ||
| pass | ||
| except KeyError as e: | ||
| _logger.warning(f"KeyError encountered: {e}") |
There was a problem hiding this comment.
Переделай на if k in log_data["request_data"] с последующим уделалением. Warning делать не надо.
openapi/controllers/pinguin.py
Outdated
Comment on lines
113
to
117
| except AttributeError: | ||
| pass | ||
| except AttributeError as e: | ||
| _logger.warning(f"AttributeError encountered: {e}") |
There was a problem hiding this comment.
Тут предлагаю переделать на hasattr(data, "ids") и убрать warning
|
Коммит который исправляет замечания выше надо объеденить с существующим коммитом precommit auto fixes. |
azimkhankuat
force-pushed
the
17.0-mig-base_api
branch
from
f3884c3 to
0012dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[17.0] [MIG] base_api, openapi