-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline Verbesserungen #11
Conversation
.github/workflows/build-all.yml
Outdated
- if: github.ref == 'refs/heads/test-pip' | ||
uses: it-at-m/.github/.github/actions/action-build-image@pipeline-feedback | ||
with: | ||
path: "${{ matrix.app-path }}" | ||
image-name: "${{ matrix.app-path }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hätte gerne diesen Step als separaten Job gehabt. Leider weiß ich nicht, wie man dann die Matrix nur einmal definiert hätte.
@simonhir gibt es noch Anmerkungen von dir? |
.github/workflows/build-all.yml
Outdated
outputs: | ||
matrix: ${{ toJSON(matrix) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
da braucht man nicht mehr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering too :D
.github/workflows/build-all.yml
Outdated
- app-path: sps-backend | ||
enable-node: false | ||
language: java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
die language muss man eigentlich gar nicht angeben. man kann ja anhand des dateipfads erkennen, ob es eine package.json oder pom.xml enthält
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the workflow in projects is probably always at least a bit different between projects
.github/workflows/build-all.yml
Outdated
strategy: | ||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Da war noch das build image in einem anderen Job. Habe gedacht das es besser ist, wenn das builden überall noch weiter läuft. So sieht man gleich, ob es mehrere Fehler gibt. Ansonsten wird es gleich im Lauf abgebrochen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok 👍 besides, anyone can change it if it bothers them
.github/workflows/build-all.yml
Outdated
outputs: | ||
matrix: ${{ toJSON(matrix) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering too :D
@simonhir passt das jetzt so. Die Pipeline wird immer komplizierter. Spotless, sonarlint, owasp muss man ja auch noch einbauen |
Description
Pipeline in eine Matrix gebaut und Node ausgelagert
Reference
Issues it-at-m/.github#18