Mdas 933 refactoring eai komponenten #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dockerfile is not needed. |
🔧 Update workflow name.
|
The spring autoconfig import is missing. The beans defined in the starter are only recognized because starter and application share the same package name. If you rename the package in the sample app to de.muenchen.mobidam1, you get: |
martind260
reviewed
Oct 16, 2024
...ommons-lib/src/main/java/de/muenchen/mobidam/eai/common/config/S3BucketCredentialConfig.java
Outdated
Show resolved
Hide resolved
martind260
reviewed
Nov 4, 2024
...m-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/config/GenericHttpStatus.java
Outdated
Show resolved
Hide resolved
...m-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/exception/IErrorResponse.java
Outdated
Show resolved
Hide resolved
...am-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/s3/S3CredentialProvider.java
Outdated
Show resolved
Hide resolved
mobidam-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/S3Constants.java
Outdated
Show resolved
Hide resolved
mobidam-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/S3Constants.java
Outdated
Show resolved
Hide resolved
mobidam-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/S3Constants.java
Outdated
Show resolved
Hide resolved
mobidam-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/S3Constants.java
Outdated
Show resolved
Hide resolved
...de/muenchen/mobidam/eai/integration/configuration/S3CredentialProviderAutoConfiguration.java
Outdated
Show resolved
Hide resolved
martind260
reviewed
Nov 8, 2024
mobidam-eai-commons-lib/src/main/java/de/muenchen/mobidam/eai/common/exception/CommonError.java
Outdated
Show resolved
Hide resolved
martind260
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring EAI Components
Short description or comments
Move common eai tasks to spring-boot starter.
Reference
Issues #MDAS-933
Definition of Done
Advice: Unchecked checkboxes are not accepted by the build pipeline. Cross out any non-relevant item by using '~~'.
- [ ] Frontend is locally smoke-testedPlease delete all side branches after merging.