Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refarch-gateway] Bug/fix hazelcast role permissions #71

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

simonhir
Copy link
Member

Description

Fix rbac resources can't be created by internal ci user.

  • Add value to enable hazelcast role and rolebinding to service account
  • Create hazelcast role only if service account enabled

@simonhir simonhir self-assigned this Nov 26, 2024
@simonhir simonhir requested a review from a team as a code owner November 26, 2024 10:57
@simonhir simonhir changed the title [refarch-gateway] Bug/refarch gateway fix hazelcast role permissions [refarch-gateway] Bug/fix hazelcast role permissions Nov 26, 2024
Copy link

@DanielOber DanielOber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit 965d69f into main Nov 26, 2024
1 check passed
@@ -2,7 +2,7 @@ apiVersion: v2
name: refarch-gateway
description: Helm chart for deploying the it@M refarch-gateway
type: application
version: 1.3.1
version: 1.3.2-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunally this version doesn't work. please make a real version 1.3.2

helm.sh/chart: refarch-gateway-1.3.1

https://github.com/it-at-m/helm-charts/blob/main/charts/sps-sample/Chart.yaml#L16

@devtobi devtobi deleted the bug/refarch-gateway-fix-hazelcast-role-permissions branch January 24, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants