dave backend IfNotPresent

[klml]

pullPolicy: IfNotPresent like anythin else

Summary by CodeRabbit

• Chores
  • Updated the application version to 0.0.7.
  • Optimized container deployment behavior to improve efficiency by reducing unnecessary image pulls.

[eidottermihi]

@klml please bump chart version / fix errors from automated checks

[coderabbitai]

Walkthrough

The pull request updates configuration files for the Helm chart. The application version in charts/dave/Chart.yaml is updated from 0.0.6 to 0.0.7, and the container image pull policy in charts/dave/charts/backend/values.yaml is changed from Always to IfNotPresent.

Changes

File(s)	Change Summary
charts/dave/Chart.yaml	Updated version from 0.0.6 to 0.0.7
charts/dave/.../values.yaml	Modified pullPolicy from Always to IfNotPresent in the image configuration

Possibly related PRs

• DAVe LS2 #84: Updates a similar version field in charts/dave/Chart.yaml, transitioning from 0.0.5 to 0.0.6.

Suggested reviewers

• gislab-augsburg

Poem

Hop, hop – I'm a coding rabbit on the run,
Updating charts swiftly, version change is done.
PullPolicy now acts with a smarter plan,
IfNotPresent saves the load, per the chart's new scan.
In this digital garden, I hop with glee – code is fun!
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a06302c and bcb5984.

📒 Files selected for processing (2)

• charts/dave/Chart.yaml (1 hunks)
• charts/dave/charts/backend/values.yaml (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Lint and Test Charts

charts/dave/Chart.yaml

[error] 1-1: INSTALLATION FAILED: context deadline exceeded

charts/dave/charts/backend/values.yaml

[error] 1-1: INSTALLATION FAILED: context deadline exceeded

🔇 Additional comments (3)

charts/dave/Chart.yaml (2)

5-5: LGTM! Version bump as requested.

The chart version has been bumped from 0.0.6 to 0.0.7 as requested by the reviewer.

---

1-33:

❓ Verification inconclusive

Investigate pipeline timeout issue.

The pipeline failure "context deadline exceeded" suggests potential timeout issues during chart installation. This could be due to the multiple chart dependencies (elasticsearch, postgresql, etc.) taking longer than expected to install.

Let's verify if there are any known issues with the chart dependencies:

---

🏁 Script executed:

#!/bin/bash
# Description: Check for any known issues with chart dependencies

# Check if the chart dependencies are accessible
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo update
helm dependency list charts/dave/

# Verify if the specified versions exist
helm search repo bitnami/elasticsearch --version 19.17.0
helm search repo bitnami/postgresql --version 14.3.3

Length of output: 704

---

Helm Environment Missing – Manual Verification Required

The investigation shows that the helm commands in the verification script failed because the helm CLI isn’t available in the pipeline environment. This prevents us from confirming whether the chart dependencies (elasticsearch, postgresql, etc.) are correctly installed and if they might be causing the "context deadline exceeded" error.

Next Steps:

• Ensure that the pipeline environment includes the helm CLI (or update the CI configuration to install helm).
• Re-run the dependency checks in an environment where helm is available to verify that the specified versions exist and that the dependencies are accessible.
• Investigate if network issues or long installation times for multiple dependencies could be contributing to the timeout.

Please perform manual verification of these points to ensure the pipeline and chart installation are correctly configured.

🧰 Tools

🪛 GitHub Actions: Lint and Test Charts

[error] 1-1: INSTALLATION FAILED: context deadline exceeded

charts/dave/charts/backend/values.yaml (1)

9-9: LGTM! Efficient image pull policy.

Changing pullPolicy to IfNotPresent is a good optimization as it:

• Reduces unnecessary image pulls when the image already exists locally
• Improves deployment efficiency and reduces network usage
• Is safe to use with the specific image tag main-ls2

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[banzuu]

@eidottermihi version has been bumped, please review again.

[eidottermihi]

@eidottermihi version has been bumped, please review again.

@gislab-augsburg @klml are CODEOWNERs for dave Chart

[banzuu]

@klml

[klml]

are CODEOWNERs for dave Chart

but I am also author of this commit, I cant review my own PR @eidottermihi can yu plz

[eidottermihi]

fix errors from automated checks

@klml @banzuu this still fails, probably because the chart cannot be installed without supplying an actual keycloak instance?

Caused by: java.lang.IllegalArgumentException: Unable to resolve Configuration with the provided Issuer of "https://sso.example.com/auth/realms/Dave"
	at org.springframework.security.oauth2.client.registration.ClientRegistrations.getBuilder(ClientRegistrations.java:268)
	at org.springframework.security.oauth2.client.registration.ClientRegistrations.fromIssuerLocation(ClientRegistrations.java:192)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesMapper.getBuilderFromIssuerIfPossible(OAuth2ClientPropertiesMapper.java:97)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesMapper.getClientRegistration(OAuth2ClientPropertiesMapper.java:71)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesMapper.lambda$asClientRegistrations$0(OAuth2ClientPropertiesMapper.java:65)
	at java.base/java.util.HashMap.forEach(HashMap.java:1429)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesMapper.asClientRegistrations(OAuth2ClientPropertiesMapper.java:64)
	at org.springframework.boot.autoconfigure.security.oauth2.client.reactive.ReactiveOAuth2ClientConfigurations$ReactiveClientRegistrationRepositoryConfiguration.clientRegistrationRepository(ReactiveOAuth2ClientConfigurations.java:58)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.lambda$instantiate$0(SimpleInstantiationStrategy.java:171)
	... 107 common frames omitted
Caused by: org.springframework.web.client.ResourceAccessException: I/O error on GET request for "https://sso.example.com/auth/realms/Dave/.well-known/openid-configuration": sso.example.com
	at org.springframework.web.client.RestTemplate.createResourceAccessException(RestTemplate.java:926)
	at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:906)
	at org.springframework.web.client.RestTemplate.exchange(RestTemplate.java:751)
	at org.springframework.security.oauth2.client.registration.ClientRegistrations.lambda$oidc$0(ClientRegistrations.java:203)
	at org.springframework.security.oauth2.client.registration.ClientRegistrations.getBuilder(ClientRegistrations.java:256)
	... 117 common frames omitted
Caused by: java.net.UnknownHostException: sso.example.com