Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cypress grouptask #1775

Merged
merged 23 commits into from
Jun 21, 2024
Merged

Feature/cypress grouptask #1775

merged 23 commits into from
Jun 21, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Jun 18, 2024

Description

Init "Example Grouptask" cypress test while refactoring existing code.

Reference

Issues: #1748

Check-List

  • All Acceptance criteria of user story are met
    - [ ] Smoketest successful (Manual E2E-Test depending on Change) Grouptask test needs frontend rebuild
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date

@simonhir simonhir self-assigned this Jun 18, 2024
@github-actions github-actions bot added digiwf-cypress cypress frontend tests feature labels Jun 18, 2024
# Conflicts:
#	digiwf-cypress/cypress.config.js
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.61%. Comparing base (ff3c988) to head (dd6276e).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1775   +/-   ##
=========================================
  Coverage     44.61%   44.61%           
  Complexity     1711     1711           
=========================================
  Files           659      659           
  Lines          9639     9639           
  Branches        484      484           
=========================================
  Hits           4300     4300           
  Misses         5154     5154           
  Partials        185      185           
Flag Coverage Δ
unittests 44.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir marked this pull request as ready for review June 19, 2024 05:30
@markostreich markostreich self-requested a review June 19, 2024 07:32
Copy link
Contributor

@markostreich markostreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nur kleine Anmerkungen.

digiwf-cypress/cypress/support/e2e.js Show resolved Hide resolved
digiwf-cypress/cypress/components/nav.js Show resolved Hide resolved
@simonhir simonhir merged commit f9ffd72 into dev Jun 21, 2024
15 checks passed
@simonhir simonhir deleted the feature/cypress-grouptask branch June 21, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants