Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1442 move duplicate s3 logic to client libs #1684

Merged
merged 20 commits into from
Jun 6, 2024

Conversation

markostreich
Copy link
Contributor

@markostreich markostreich commented May 15, 2024

Description

Reference

Issues: #xxx

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change - See Dependency Graph)
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 63.97516% with 58 lines in your changes missing coverage. Please review.

Project coverage is 44.65%. Comparing base (6f7c1ae) to head (90d8a3a).
Report is 3 commits behind head on dev.

Files Patch % Lines
...e/client/controller/ClientFileUsageController.java 0.00% 13 Missing ⚠️
...giwf/dms/integration/adapter/out/s3/S3Adapter.java 68.00% 7 Missing and 1 partial ⚠️
.../repository/transfer/S3FileTransferRepository.java 68.00% 8 Missing ⚠️
...f/ticket/integration/adapter/out/s3/S3Adapter.java 46.15% 7 Missing ⚠️
...n/api/resource/ServiceStartFileRestController.java 0.00% 4 Missing ⚠️
...nition/domain/service/ServiceStartFileService.java 0.00% 4 Missing ⚠️
...nce/domain/service/ServiceInstanceFileService.java 0.00% 4 Missing ⚠️
...en/oss/digiwf/shared/file/AbstractFileService.java 0.00% 3 Missing ⚠️
...tegration/client/service/FileExtensionService.java 82.35% 2 Missing and 1 partial ⚠️
...client/controller/ClientFolderUsageController.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1684      +/-   ##
============================================
- Coverage     44.73%   44.65%   -0.09%     
- Complexity     1706     1707       +1     
============================================
  Files           653      656       +3     
  Lines          9629     9592      -37     
  Branches        477      482       +5     
============================================
- Hits           4308     4283      -25     
+ Misses         5139     5124      -15     
- Partials        182      185       +3     
Flag Coverage Δ
unittests 44.65% <63.97%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich self-assigned this May 16, 2024
@markostreich markostreich marked this pull request as ready for review May 21, 2024 08:54
@markostreich markostreich requested a review from lehju May 21, 2024 08:54
Copy link
Contributor

@lehju lehju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der Multi File Input funktioniert bei mir nicht mehr.

@markostreich
Copy link
Contributor Author

Der Multi File Input funktioniert bei mir nicht mehr.

@lehju Sollte nun repariert sein.

Copy link
Contributor

@lehju lehju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jetzt startet bei mir die Tasklist nicht mehr. Hast du das Problem auch?

@lehju lehju merged commit a97a066 into dev Jun 6, 2024
27 of 29 checks passed
@lehju lehju deleted the feature/1442-move-duplicate-s3-logic-to-client-libs branch June 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move duplicate s3 logic to client libs
2 participants