Fix tcp telemetry for service-oriented waypoints #5968
+295
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
size/M
zirain
reviewed
Dec 14, 2024
There was a problem hiding this comment.
I think these are proto generator changes that @howardjohn or @craigbox have been working on
There was a problem hiding this comment.
That is from istio/tools#3064. There will be more coming from my recent PRs, which will remove some <th> and <td> and move things around.
zirain
reviewed
Dec 16, 2024
keithmattix
force-pushed
the
fix-tcp-ambient-metrics
branch
from
47449a6 to
2750f0f
Compare
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
istio-testing
added
the
needs-rebase
keithmattix
force-pushed
the
fix-tcp-ambient-metrics
branch
from
2750f0f to
4c1a543
Compare
istio-testing
removed
the
needs-rebase
|
@keithmattix: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The metadata_exchange filter only looks at downstream metadata; this PR configures it to check upstream metadata and store it in filter state (with the appropriate key) if it exists. Note that workload oriented waypoints are still broken because those endpoints have no metadata. /cc @howardjohn on where to make the control plane adjustments there.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): part of istio/istio#53593Special notes for your reviewer:
Replaces #5963 for adding a compdb script; if you want to review #5963 on its own; I'll rebase this PR once that one is done.