Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] zh-translation: /blog/2019/performance-best-practices/index.md #7439

Closed
wants to merge 3 commits into from
Closed

[release-1.6] zh-translation: /blog/2019/performance-best-practices/index.md #7439

wants to merge 3 commits into from

Conversation

istio-testing
Copy link
Contributor

This is an automated cherry-pick of #7090

@istio-testing istio-testing requested a review from a team as a code owner June 1, 2020 15:39
@istio-testing istio-testing mentioned this pull request Jun 1, 2020
Merged
@istio-testing istio-testing added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 1, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2020
@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Jun 1, 2020
@frankbu frankbu added the translation/chinese Translation item label Jun 1, 2020
@AsCat
Copy link
Member

AsCat commented Aug 26, 2020

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Aug 26, 2020
@AsCat
Copy link
Member

AsCat commented Aug 26, 2020 •
edited
Loading

The issue is fixed in release-1.6 branch, can anyone help close this PR. @istio/wg-docs-maintainers-chinese

@ericvn
Copy link
Contributor

ericvn commented Nov 9, 2020

Per @AsCat, closing this PR

@ericvn ericvn closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AsCat AsCat

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@istio-testing @googlebot @AsCat @ericvn @frankbu