-
Notifications
You must be signed in to change notification settings - Fork 1.6k
update ingress documentation to prefer ingressclass #16386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ingress documentation to prefer ingressclass #16386
Conversation
Signed-off-by: tjons <[email protected]>
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Signed-off-by: tjons <[email protected]>
I think the test would rather the path remained |
content/en/docs/tasks/traffic-management/ingress/kubernetes-ingress/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/traffic-management/ingress/kubernetes-ingress/snips.sh
Outdated
Show resolved
Hide resolved
Attempt to fix test
You need to remove these lines from test.sh, which I don't have access to do on your PR I'm sorry
|
Signed-off-by: tjons <[email protected]>
I got sidetracked... @craigbox thanks for taking a look! |
In response to a cherrypick label: new pull request created: #16405 |
Description
Rework the flow of the https://istio.io/latest/docs/tasks/traffic-management/ingress/kubernetes-ingress/ page to point users towards using
IngressClass
, rather than the deprecatedkubernetes.io/ingress.class
annotation. Resolves #16188Reviewers