Skip to content

update ingress documentation to prefer ingressclass #16386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

tjons
Copy link
Contributor

@tjons tjons commented Apr 6, 2025

Description

Rework the flow of the https://istio.io/latest/docs/tasks/traffic-management/ingress/kubernetes-ingress/ page to point users towards using IngressClass, rather than the deprecated kubernetes.io/ingress.class annotation. Resolves #16188

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@tjons tjons requested a review from a team as a code owner April 6, 2025 02:26
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2025
Signed-off-by: tjons <[email protected]>
@craigbox
Copy link
Contributor

craigbox commented Apr 8, 2025

I think the test would rather the path remained /status. (Test output)

@craigbox
Copy link
Contributor

You need to remove these lines from test.sh, which I don't have access to do on your PR I'm sorry

# Test IngressClass and pathType
kubectl apply -f - <<< "$snip_specifying_ingressclass_1"

get_headers() {
curl -s -H "Foo: bar" -HHost:httpbin.example.com "http://$INGRESS_HOST:$INGRESS_PORT/headers" | jq '.headers["Foo"][0]'
}
_verify_contains get_headers '"bar"'

Signed-off-by: tjons <[email protected]>
@tjons
Copy link
Contributor Author

tjons commented Apr 11, 2025

I got sidetracked... @craigbox thanks for taking a look!

@istio-testing istio-testing merged commit 44f91dd into istio:master Apr 11, 2025
13 checks passed
@craigbox craigbox added the cherrypick/release-1.25 Set this label on a PR to auto-merge it to the release-1.25 branch label Apr 11, 2025
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #16405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.25 Set this label on a PR to auto-merge it to the release-1.25 branch kind/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kubernetes Ingress Documentation to push users to modern paths
4 participants