Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multicluster] gateway api tests need not install istio gateways #15662

Merged
merged 1 commit into from
Sep 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions content/en/docs/setup/install/external-controlplane/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,18 @@ _verify_like snip_deploy_a_sample_application_3 "$snip_deploy_a_sample_applicati

_verify_contains snip_deploy_a_sample_application_4 "Hello version: v1"

# Install ingress with istioctl
echo y | snip_enable_gateways_1
if [ "$GATEWAY_API" != "true" ]; then
# Install ingress with istioctl
echo y | snip_enable_gateways_1

# And egress with helm
_rewrite_helm_repo snip_enable_gateways_4
# And egress with helm
_rewrite_helm_repo snip_enable_gateways_4

_verify_same kubectl_get_egress_gateway_for_remote_cluster "Running"
_verify_same kubectl_get_egress_gateway_for_remote_cluster "Running"
fi

if [ "$GATEWAY_API" == "true" ]; then
snip_install_crds
snip_configure_and_test_an_ingress_gateway_4
snip_configure_and_test_an_ingress_gateway_6
else
Expand Down