Skip to content

Remove non-zero requirement on connectionPool.tcp.IdleTimeout #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions kubernetes/customresourcedefinitions.gen.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions networking/v1alpha3/destination_rule.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions networking/v1alpha3/destination_rule.proto
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,7 @@ message ConnectionPoolSettings {
// because idleTimeout is a property of a listener, not a cluster. In that case, idleTimeout
// specified in a destination rule for the first weighted route is configured in the listener,
// which means also for all weighted routes.
// +protoc-gen-crd:duration-validation:none
google.protobuf.Duration idle_timeout = 5;
};

Expand Down