Skip to content

Commit

Permalink
mark extraStatTags deprecated (#3037)
Browse files Browse the repository at this point in the history
* mark extraStatTags deprecated

* release-notes

* fix gen
  • Loading branch information
zirain authored Jan 9, 2024
1 parent a6b42df commit 5e4450d
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion annotation/annotations.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions annotation/annotations.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion annotation/annotations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ annotations:
- name: sidecar.istio.io/extraStatTags
featureStatus: Alpha
description: An additional list of tags to extract from the in-proxy Istio Wasm telemetry. Each additional tag needs to be present in this list.
deprecated: false
deprecated: true
hidden: false
resources:
- Pod
Expand Down
3 changes: 2 additions & 1 deletion mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions mesh/v1alpha1/proxy.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions mesh/v1alpha1/proxy.proto
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ message ProxyConfig {
// added by configuring the telemetry extension. Each additional tag needs to be present in this list.
// Extra tags emitted by the telemetry extensions must be listed here so that they can be processed
// and exposed as Prometheus metrics.
// Deprecated: `istio.stats` is a native filter now, this field is no longer needed.
repeated string extra_stat_tags = 27;

// Topology encapsulates the configuration which describes where the proxy is
Expand Down
6 changes: 6 additions & 0 deletions releasenotes/notes/deprecated-extrastattags.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: release-notes/v2
kind: feature
area: telemetry
releaseNotes:
- |
**Deprecated** extraStatTags in MeshConfig and annotations. This field will be removed in a future release.

0 comments on commit 5e4450d

Please sign in to comment.