Fix env variable name for VerifyCertAtClient (#3012)

Signed-off-by: Faseela K <[email protected]>
istio · Dec 5, 2023 · 515df8d · 515df8d
1 parent 342d60d
commit 515df8d
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 45 deletions.
diff --git a/kubernetes/customresourcedefinitions.gen.yaml b/kubernetes/customresourcedefinitions.gen.yaml
diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go
diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html
diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
@@ -1151,16 +1151,16 @@ message ClientTLSSettings {
   // environmental variable is set to `true`.
   string sni = 6;
 
-  // InsecureSkipVerify specifies whether the proxy should skip verifying the
+  // `insecureSkipVerify` specifies whether the proxy should skip verifying the
   // CA signature and SAN for the server certificate corresponding to the host.
   // This flag should only be set if global CA signature verification is
-  // enabled, `VerifyCertAtClient` environmental variable is set to `true`,
+  // enabled, `VERIFY_CERTIFICATE_AT_CLIENT` environmental variable is set to `true`,
   // but no verification is desired for a specific host. If enabled with or
-  // without `VerifyCertAtClient` enabled, verification of the CA signature and
+  // without `VERIFY_CERTIFICATE_AT_CLIENT` enabled, verification of the CA signature and
   // SAN will be skipped.
   //
-  // `InsecureSkipVerify` is `false` by default.
-  // `VerifyCertAtClient` is `false` by default in Istio version 1.9 but will
+  // `insecureSkipVerify` is `false` by default.
+  // `VERIFY_CERTIFICATE_AT_CLIENT` is `false` by default in Istio version 1.9 but will
   // be `true` by default in a later version where, going forward, it will be
   // enabled by default.
   google.protobuf.BoolValue insecure_skip_verify = 8;

diff --git a/networking/v1beta1/destination_rule.pb.go b/networking/v1beta1/destination_rule.pb.go
diff --git a/networking/v1beta1/destination_rule.proto b/networking/v1beta1/destination_rule.proto
@@ -1100,16 +1100,16 @@ message ClientTLSSettings {
   // environmental variable is set to `true`.
   string sni = 6;
 
-  // InsecureSkipVerify specifies whether the proxy should skip verifying the
+  // `insecureSkipVerify` specifies whether the proxy should skip verifying the
   // CA signature and SAN for the server certificate corresponding to the host.
   // This flag should only be set if global CA signature verification is
-  // enabled, `VerifyCertAtClient` environmental variable is set to `true`,
+  // enabled, `VERIFY_CERTIFICATE_AT_CLIENT` environmental variable is set to `true`,
   // but no verification is desired for a specific host. If enabled with or
-  // without `VerifyCertAtClient` enabled, verification of the CA signature and
+  // without `VERIFY_CERTIFICATE_AT_CLIENT` enabled, verification of the CA signature and
   // SAN will be skipped.
   //
-  // `InsecureSkipVerify` is `false` by default.
-  // `VerifyCertAtClient` is `false` by default in Istio version 1.9 but will
+  // `insecureSkipVerify` is `false` by default.
+  // `VERIFY_CERTIFICATE_AT_CLIENT` is `false` by default in Istio version 1.9 but will
   // be `true` by default in a later version where, going forward, it will be
   // enabled by default.
   google.protobuf.BoolValue insecure_skip_verify = 8;