fix(dialect): 正确处理字符串包含单引号的问题

issue9 · May 4, 2024 · b8d1018 · b8d1018
1 parent c805e35
commit b8d1018
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/dialect/base.go b/dialect/base.go
@@ -6,10 +6,16 @@ package dialect
 
 import (
 	"os/exec"
+	"strings"
 
 	"github.com/issue9/sliceutil"
 )
 
+var (
+	quoteApostrophe  = strings.NewReplacer("'", "''")  // 标准 SQL 用法
+	escapeApostrophe = strings.NewReplacer("'", "\\'") // mysql 用法
+)
+
 type base struct {
 	driverName     string
 	name           string

diff --git a/dialect/mysql.go b/dialect/mysql.go
@@ -285,7 +285,7 @@ func (m *mysql) formatSQL(col *core.Column) (f string, err error) {
 		}
 		return "0", nil
 	case string:
-		return "'" + vv + "'", nil
+		return "'" + escapeApostrophe.Replace(vv) + "'", nil
 	case time.Time: // datetime
 		return formatTime(col, vv)
 	case sql.NullTime: // datetime

diff --git a/dialect/postgres.go b/dialect/postgres.go
@@ -255,7 +255,7 @@ func (p *postgres) formatSQL(col *core.Column) (f string, err error) {
 
 	switch vv := v.(type) {
 	case string:
-		return "'" + vv + "'", nil
+		return "'" + quoteApostrophe.Replace(vv) + "'", nil
 	case time.Time: // timestamp
 		return formatTime(col, vv)
 	case sql.NullTime: // timestamp

diff --git a/dialect/sqlite3.go b/dialect/sqlite3.go
@@ -336,7 +336,7 @@ func (s *sqlite3) formatSQL(v any) (f string, err error) {
 
 	switch vv := v.(type) {
 	case string:
-		return "'" + vv + "'", nil
+		return "'" + quoteApostrophe.Replace(vv) + "'", nil
 	case time.Time: // timestamp
 		return "'" + vv.In(time.UTC).Format(datetimeLayouts[0]) + "'", nil
 	case sql.NullTime: // timestamp