add Searchbar for projects list and sitemaps list #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only request is to make the search bar longer, it will look visually better |
mxsnq
reviewed
Jan 16, 2025
There was a problem hiding this comment.
- We already use this jquery plugin to search entries in browse data menu. See browseSitemapData method in Controller.js. See if you can reuse it for project/sitemap lists.
- It would be awesome if you manage to tweak with styles so table columns do not change their widths after search. I'd try to add
width: N%(or bootstrap's col- classes) for columns, also maybeoverflow-wrap: anywherefor cell contents. - Consider also allowing search by project ids and sitemap urls
src/scripts/Controller.js
Outdated
Comment on lines
869
to
874
| let AllRows = []; | ||
| const inputText = event.target.value.toLowerCase(); | ||
| AllRows = Array.from(document.querySelectorAll(rowSelector)).map( | ||
| td => td.parentElement | ||
| ); | ||
| AllRows.forEach(row => { |
There was a problem hiding this comment.
AllRows could be const. Also, allRows.
src/scripts/Controller.js
Outdated
| const rowText = row.querySelector(rowSelector).innerText; | ||
| if (rowText.toLowerCase().includes(inputText)) { | ||
| row.style.display = 'table-row'; | ||
| let regex = RegExp(inputText, 'gi'); |
There was a problem hiding this comment.
If sitemap id or project name contain special regex characters like +, (), search will work, but highlight might be off
src/scripts/Controller.js
Outdated
| } | ||
|
|
||
| initSearchbar(rowSelector) { |
There was a problem hiding this comment.
rowSelector seems to be a cell selector
|
also don't forget to merge master and fix conflicts |
# Conflicts: # src/_locales/en/messages.json # src/_locales/ru/messages.json
|
jquery searcher has been added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.