TLDR 531 pdf_txtlayer_reader table fix #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*corresponding tests are in test_module_table_detection
NastyBoget
reviewed
Nov 30, 2023
NastyBoget
reviewed
Nov 30, 2023
...mage_reader/table_recognizer/table_extractors/concrete_extractors/onepage_table_extractor.py
Outdated
Show resolved
Hide resolved
|
Давай еще сделаем unit тест с простеньким файликом с табличкой (можно из ишшьи взять) |
oksidgy
reviewed
Nov 30, 2023
...mage_reader/table_recognizer/table_extractors/concrete_extractors/onepage_table_extractor.py
Show resolved
Hide resolved
oksidgy
reviewed
Nov 30, 2023
* deleted path_cells at all * fixed path creating
* one small bug fixed * if debug_modeis not chossen in test config, then test doesn't pass
* path_detect forword fix * some debug_mode and path_debug bugs fixed
NastyBoget
reviewed
Dec 1, 2023
dedoc/readers/pdf_reader/pdf_image_reader/table_recognizer/table_utils/img_processing.py
Outdated
Show resolved
Hide resolved
NastyBoget
reviewed
Dec 1, 2023
dedoc/readers/pdf_reader/pdf_image_reader/table_recognizer/table_utils/img_processing.py
Outdated
Show resolved
Hide resolved
NastyBoget
reviewed
Dec 1, 2023
dedoc/readers/pdf_reader/pdf_image_reader/table_recognizer/table_utils/img_processing.py
Outdated
Show resolved
Hide resolved
NastyBoget
reviewed
Dec 1, 2023
dedoc/readers/pdf_reader/pdf_image_reader/table_recognizer/table_utils/img_processing.py
Outdated
Show resolved
Hide resolved
NastyBoget
reviewed
Dec 1, 2023
dedoc/readers/pdf_reader/pdf_image_reader/table_recognizer/table_recognizer.py
Show resolved
Hide resolved
NastyBoget
reviewed
Dec 1, 2023
| @@ -52,7 +52,7 @@ def __init__(self, *, config: dict) -> None: | |||
| self.binarizer = AdaptiveBinarizer() | |||
| self.ocr = OCRLineExtractor(config=config) | |||
| self.logger = config.get("logger", logging.getLogger()) | |||
| if self.config.get("debug_mode") and not os.path.exists(self.config["path_debug"]): | |||
| if self.config.get("debug_mode", False) and not os.path.exists(self.config["path_debug"]): | |||
There was a problem hiding this comment.
Насчет debug_mode:
выбери что тебе больше нравится: config.get("debug_mode") или config.get("debug_mode", False) (или что проще править), и давай сделаем везде одинаково. Хотя все равно в процессе разработки кто как будет писать.
Насчет path_debug лучше просто .get("path_debug")
oksidgy
reviewed
Dec 1, 2023
* path_detect forword style changed * img_processing.pt:146 - get_config()["debug_mode"] fixed * ocr_cell_extractor.py - changed if False to if NoneType is None
NastyBoget
added a commit
that referenced
this pull request
Dec 25, 2023
* TLDR 531 pdf_txtlayer_reader table fix (#380) * TLDR-538 tesseract trustai (#377) * fixed training script (#383) * TLDR-521 Fix splittext for file names with several dots (#385) * TLDR-527 refactor methods and parameters for all main classes (#387) * Add attach and table annotations to PPTX (#389) * TLDR-544 docx bugs (#382) * TLDR-516 GPU in docker (#384) * new version 2.0 (#390) --------- Co-authored-by: raxtemur <[email protected]> Co-authored-by: Oksana Belyaeva <[email protected]> Co-authored-by: Alexander Golodkov <[email protected]> Co-authored-by: Alexander Golodkov <[email protected]> Co-authored-by: Nikita Shevtsov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.