Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video issue in Android #44

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Conversation

gdimitris
Copy link
Contributor

Hello @isonic1 ,

This is another PR from me :)

This fixes #39 and #40

The problem

Video for Android seems to not work for videos larger than 3 mins

The cause

Results from md5sum on the video directory were not parsed correctly.
In detail, while the videos were saved correctly in sdcard/flick , the output was not split correctly causing only the first video to be output.

The solution

The solution is to use a regexp to parse the files correctly and add them into the hash for later processing. I also had to sort the results from Dir.glob because in my mac the results were not sorted causing wrong sequences in the final video.

@gdimitris
Copy link
Contributor Author

@isonic1 I will also have some spare time to contribute this week so if you have any major issues to look at let me know.

@isonic1
Copy link
Owner

isonic1 commented Oct 27, 2018

@gdimitris thanks again for the help with this! It's much appreciated! ❤️ Outside of the issues you've fixed already I don't know of any others. A couple seem to be environmental issues but would need to doublecheck. I think the last thing I want to do for this project is to make it runnable on Windows (at least for android). But I wouldn't expect you to help with that unless you want to. :)

@isonic1 isonic1 merged commit c7daea9 into isonic1:master Oct 27, 2018
@gdimitris
Copy link
Contributor Author

Happy to help, but I don't currently have a Windows machine at my disposal so it will take a while for that.
I plan to make the following additions:

@isonic1
Copy link
Owner

isonic1 commented Oct 27, 2018

Thanks, @gdimitris. Those all sound great! Yeah, the specs really haven't been updated since I first pushed this repo a few years back. So any help with those would be awesome. I've gotten by with testing manually each time knowing I should update them. ;)

I guess one other thing I was going to look into adding iOS simulator recoding based on this feedback.

@gdimitris
Copy link
Contributor Author

Ok perfect @isonic1 👍 , I can also check #11
I will let you know once I have something working

@gdimitris gdimitris deleted the fix_android_video branch October 27, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flick can't record extended video for Android OS 8.0
2 participants