-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first commit biascorrection #2
Conversation
@erwinlambert, can you provide me with the following that would help me review this? What packages do I need to run the scripts and notebook? Is there some way for me to usefully run the code? If not, that's fine. I can just inspect it. |
@xylar , I was actually just writing up an email to suggest Nico to review the code, as we'll need to exchange and collaborate mostly. Still, if you do want to review, the list of packages is:
However, the code won't run without the data I'm afraid, which is a whole bunch of large cmip output files |
@erwinlambert, I just invited @nicolasjourdain to join the the repo. I think it's best for him to review. This looks good to me at a quick glance. |
@erwinlambert, I think this looks good. The code is clean and will be easy to incorporate into a package in the near future so it's easier to share code between parts of our project. |
Great, I will see whether @nicolasjourdain wants to have a look as well. Otherwise I'll merge the code as a starting point |
@erwinlambert, I think this can either go in as it is and then be reorganized to work in the |
@nicojourdain, please have a look as well when you have a chance. |
je ne veux pas travailler sur ce projet |
@nicolasjourdain, there is nothing we can do to remove you. You will need to choose to "unwatch" the project. Once you have been mentioned, GitHub will automatically keep notifying you about a given PR. I am sorry we can't remove you and that we mentioned you by mistake. |
@xylar I will merge the version as is. Then we can later reorganise this into the package |
First code for the bias correction method in T-S space from Naughten et al.
The biascorr/src/ folder contains relatively clean code and general (plotting) functions, the biascorr/notebooks/ folder contains more messy code to plot examples.
(See if this works:)
Closes #1