Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/joh 13 login register #4

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Conversation

punchanabu
Copy link
Member

The things that I do

  • register and login UI in app/login and app/register
  • add color johnjud-light-gray for the input background in tailwind.config.js
  • add form icon in assets
  • add Form component in component/Form

Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

มีนิดนึง อยากให้ submit button อยู่ใน component เดียวกับ form และอยู่ใต้ tag <form></form> เพราะว่า เดี๋ยวตอน Integrate api เข้าไปจะได้ใช้ react-hook-form ได้เลย

src/components/Form/SubmitButton.tsx Outdated Show resolved Hide resolved
@punchanabu
Copy link
Member Author

แก้ละะ

  • move submitButton to be the child of the form
  • add type = "submit" to submitButton component

Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@punchanabu punchanabu merged commit bcaae93 into dev Dec 22, 2023
1 check passed
@punchanabu punchanabu deleted the feature/joh-13-login-register branch January 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants