feat: pet svc delete use image's deletebypetid

isd-sgcu · Feb 17, 2024 · 932ff3b · 932ff3b
1 parent a3a3933
commit 932ff3b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/app/service/pet/pet.service.go b/src/app/service/pet/pet.service.go
@@ -253,6 +253,12 @@ func (s *Service) Delete(id string) (result *dto.DeleteResponse, err *dto.Respon
 			}
 		}
 	}
+
+	_, errSvc := s.imageService.DeleteByPetId(id)
+	if errSvc != nil {
+		return nil, errSvc
+	}
+
 	return &dto.DeleteResponse{
 		Success: res.Success,
 	}, nil

diff --git a/src/app/service/pet/pet.service_test.go b/src/app/service/pet/pet.service_test.go
@@ -543,19 +543,26 @@ func (t *PetServiceTest) TestUpdateUnavailableServiceError() {
 }
 
 func (t *PetServiceTest) TestDeleteSuccess() {
-	protoReq := &petproto.DeletePetRequest{
+	petProtoReq := &petproto.DeletePetRequest{
 		Id: t.Pet.Id,
 	}
-	protoResp := &petproto.DeletePetResponse{
+	petProtoResp := &petproto.DeletePetResponse{
+		Success: true,
+	}
+	imageProtoReq := &imgproto.DeleteByPetIdRequest{
+		PetId: t.Pet.Id,
+	}
+	imageProtoResp := &imgproto.DeleteByPetIdResponse{
 		Success: true,
 	}
 
 	expected := &dto.DeleteResponse{Success: true}
 
 	client := &petmock.PetClientMock{}
-	client.On("Delete", protoReq).Return(protoResp, nil)
+	client.On("Delete", petProtoReq).Return(petProtoResp, nil)
 
 	imageClient := imagemock.ImageClientMock{}
+	imageClient.On("DeleteByPetId", imageProtoReq).Return(imageProtoResp, nil)
 
 	imageSvc := imageSvc.NewService(&imageClient)
 	svc := NewService(client, imageSvc)