Python: Allow a FeatureSource to be used multiple times

isciences · May 1, 2024 · ad54abf · ad54abf
1 parent 0b924f9
commit ad54abf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/python/src/pybindings/feature_source_bindings.cpp b/python/src/pybindings/feature_source_bindings.cpp
@@ -38,6 +38,7 @@ class PyFeatureSourceBase : public FeatureSource
 
         auto iter = py::iter(m_it);
         if (iter == py::iterator::sentinel()) {
+            m_initialized = false;
             return false;
         }
         m_feature = py::cast<py::object>(*iter);

diff --git a/python/tests/test_feature_source.py b/python/tests/test_feature_source.py
@@ -22,6 +22,7 @@ def test_gdal_feature_source():
     fs = GDALFeatureSource(lyr)
 
     assert fs.count() == 5
+    assert fs.count() == 5  # make sure we can iterate twice
 
 
 def test_python_feature_source():
@@ -39,3 +40,4 @@ def test_python_feature_source():
     fs = JSONFeatureSource(features)
 
     assert fs.count() == 5
+    assert fs.count() == 5