Upload CI artifacts on "push" triggers only #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uploaded CI artifacts are currently used for publishing to PyPI (or TestPyPI). The `publish-to-pypi` and `publish-to-testpypi` jobs are only triggered by "push" events -- otherwise the uploaded CI artifacts go unused. In order to avoid wasting resources, let's upload CI artifacts only on "push" events.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 9 9
Lines 449 449
=======================================
Hits 422 422
Misses 27 27 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploaded CI artifacts (including wheels and sdists) are currently used for publishing to PyPI (or TestPyPI). The
publish-to-pypiandpublish-to-testpypijobs are only triggered by "push" events -- otherwise these uploaded artifacts simply go unused.A significant portion of CI runs are triggered by PRs, which don't need these artifacts. In order to avoid wasting resources, let's upload CI artifacts only on "push" events.
We'll still continue to run the jobs which generate these artifacts for testing purposes. The artifacts will just be discarded when the job finishes.