Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s1_info.py to take care of antimeridian-crossing #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seongsujeong
Copy link
Contributor

This PR is to take care of the case that the S1 frame's area crosses antimeridian when s1_info.py computes the bounding box. The fix is based on the code here

Before:

% python s1_info.py S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip --frame-bbox
Found 1 Sentinel-1 SLC products.
S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip: [-177.710968, 50.39941, 179.223694, 52.575905]

After:

% python s1_info.py S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip --frame-bbox
Found 1 Sentinel-1 SLC products.
S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip: [178.642044, 50.39941, 182.728027, 52.575905]

@seongsujeong seongsujeong requested a review from gshiroma August 28, 2023 17:48
Copy link
Contributor

@gshiroma gshiroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @seongsujeong . I'm not familiar with that function. Please, make sure the any code that calls it can handle longitude values greater than +180 degrees.

@seongsujeong
Copy link
Contributor Author

seongsujeong commented Aug 28, 2023

AFAICT, neither COMPASS nor RTC is using this code in the workflow. git grep does not return anything.
Therefore I think the PR should not affect the downstream workflows.

(isce3_0.14.0) COMPASS% git grep _bounds_from_preview
(isce3_0.14.0) COMPASS% git grep s1_info

(isce3_0.14.0) RTC% git grep _bounds_from_preview
(isce3_0.14.0) RTC% git grep s1_info

@gshiroma
Copy link
Contributor

AFAICT, neither COMPASS nor RTC is using this code in the workflow. git grep does not return anything. Therefore I think the PR should not affect the downstream workflows.

(isce3_0.14.0) COMPASS% git grep _bounds_from_preview
(isce3_0.14.0) COMPASS% git grep s1_info

(isce3_0.14.0) RTC% git grep _bounds_from_preview
(isce3_0.14.0) RTC% git grep s1_info

Thank you, @seongsujeong . It looks like the function is used here, which seems to be used to inform the frame bbox here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants