Skip to content

Commit

Permalink
[#1150] address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
andrei-pavel committed Feb 2, 2024
1 parent 59c3fad commit 4282de9
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
2 changes: 2 additions & 0 deletions webui/src/app/help-tip/help-tip.component.sass
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
color: #007ad9

.help-tip
// Do not let tips be too narrow on small-screen devices. But also not wider than max-width.
min-width: min(22rem, 60vw)
// help box max width should be not larger than 60% of window width
max-width: 60vw
font-weight: normal
Expand Down
2 changes: 1 addition & 1 deletion webui/src/app/help-tip/help-tip.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class HelpTipComponent {
/**
* Width of the help box.
*/
@Input() width = '32vw'
@Input() width = '20vw'

/**
* A class for icon with question mark.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
Use the input box to specify a searched lease. You can search the lease by one of the following
lease properties:
</p>
<table class="alternate-row-colors">
<table class="alternate-list">
<tr>
<th></th>
<th>kea-dhcp4</th>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@
:host ::ng-deep .leases-search-spinner
margin-left: 15px
margin-right: 15px

.alternate-row-colors tr:nth-child(2n+1)
background-color: #f4f4f4
4 changes: 2 additions & 2 deletions webui/src/styles.sass
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ p-header
margin-left: 20px
color: #848484

// Utility class for highlighting every even list item.
.alternate-list:nth-child(2n)
// Utility class for highlighting every even list item or table row.
.alternate-list:nth-child(2n), .alternate-list tr:nth-child(2n)
background-color: #f4f4f4

// Allows breaking long lines of text on small
Expand Down

0 comments on commit 4282de9

Please sign in to comment.