Skip to content

Commit 1ecb2d1

Browse files
ozhanozenMayankm96
authored andcommitted
Changes 'unalias' to 'unset' inside setup_conda_env in orbit.sh (#378)
The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()` prevents `orbit.sh --conda` to successfully exit. The "`unset`" command rather than "`unalias`" should be used for environment variables (e.g., `ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used to directly install conda during the image build process: the image build process is interrupted. Fixes #377 - Bug fix (non-breaking change which fixes an issue) Before: https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148 After: `'unset ORBIT_PATH' \` - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent a642b8e commit 1ecb2d1

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Guidelines for modifications:
3939
* Jia Lin Yuan
4040
* Jingzhou Liu
4141
* Kourosh Darvish
42+
* Özhan Özen
4243
* Qinxi Yu
4344
* René Zurbrügg
4445
* Ritvik Singh

orbit.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ setup_conda_env() {
145145
printf '%s\n' '#!/usr/bin/env bash' '' \
146146
'# for orbit' \
147147
'unalias orbit &>/dev/null' \
148-
'unalias ORBIT_PATH &>/dev/null' \
148+
'unset ORBIT_PATH' \
149149
'' \
150150
'# for isaac-sim' \
151151
'unset CARB_APP_PATH' \

0 commit comments

Comments
 (0)