Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic route ops with multi-hops #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support dynamic route ops with multi-hops #18

wants to merge 1 commit into from

Conversation

byteocean
Copy link
Contributor

Proposed Changes

Added support of dynamic route operations into kernel, e.g., add/remove. Multiple hops can be associated to a single route.

@github-actions github-actions bot added the size/L label Jun 7, 2022
@byteocean byteocean force-pushed the nl branch 2 times, most recently from 857b41c to 436ea7a Compare June 7, 2022 08:48
@github-actions github-actions bot added size/M and removed size/L labels Jun 7, 2022
@MalteJ
Copy link
Contributor

MalteJ commented Jun 7, 2022

Please keep track of the nexthops by your own.

You should not call into metalbond to get a nexthop list (e.g. c.mbOwner.routeTable.GetNextHopsByDestination(vni, dest)).
MetalBond is multi-threaded and the call you are doing here may return a list that ist not consistent with the incremental updates you receive via the MetalBond Client interface.

Please use routeTable to keep track of your nexthops.
Then you also don't need to add a SetOwner method to the MetalBond Client Interface.

@byteocean
Copy link
Contributor Author

In order to reduce the usage of synchronisation objects such as mutex, a thread unsafe routing table for key routing information is added based on the existing thread-safe routing table. It is supposed to be used in a single thread.

@MalteJ MalteJ changed the title Support dynamic route ops with muti -hops. Support dynamic route ops with multi-hops Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants