Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code generators #54

Merged
merged 2 commits into from
May 14, 2024
Merged

Update code generators #54

merged 2 commits into from
May 14, 2024

Conversation

Gchbg
Copy link
Collaborator

@Gchbg Gchbg commented Apr 29, 2024

Release note:

Update code generators

@Gchbg
Copy link
Collaborator Author

Gchbg commented May 13, 2024

This cannot be merged yet because the 0.30.0 release of code-generator has a last minute bug that breaks our stuff. The fix will be in the next release.

@Gchbg Gchbg marked this pull request as ready for review May 14, 2024 14:45
@Gchbg
Copy link
Collaborator Author

Gchbg commented May 14, 2024

This cannot be merged yet because the 0.30.0 release of code-generator has a last minute bug that breaks our stuff. The fix will be in the next release.

Since make generate is no longer part of make test, this is no longer a blocker. Until the next code-generator release, applyconfiguration-gen will generate incorrect code that does not compile. If code generation is needed, this can be worked around by compiling applyconfiguration-gen manually from the master branch of code-generator.

@Gchbg Gchbg disabled auto-merge May 14, 2024 22:42
@Gchbg Gchbg merged commit 85a19d6 into main May 14, 2024
6 checks passed
@Gchbg Gchbg deleted the chore/gen branch May 14, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant