PoC: BIOS version & settings management

[aobort]

Proposed Changes

This PR contains PoC implementation for management of server's BIOS version and settings:

• API types
• Controller
• Service managing tasks (scan, apply settings, update version)

This approach fully separate concrete job implementation from the reconciliation flow.

To discuss

BootOrder

Do we need to move boot order field from server to serverBIOS CR? Semantically, yes. As it's one of BIOS settings.

BIOS settings in .status

From my perspective, it reasonable to reflect in .status.bios.settings only those settings which are set in .spec.bios.settings. This will make comparison of .spec and .status much easier.

Storing bios settings

Do we need custom type for bios setting:

type SettingsEntry struct {
    // +required
    Name string `json:"name"`
    
    // +required
    Value string `json:"value"`
        
    // +optional
    Unsupported bool `json:"unsupported,omitempty"`
}

to avoid attempting to apply settings which are not supported in the specified BIOS version? I.e.:

apiVersion: metal.ironcore.dev/v1alpha1
kind: ServerBIOS
metadata:
  name: foo
spec:
  scanPeriodMinutes: 30
  serverRef:
    name: bar
  bios:
    # changing both version and 'unsupported' flag in the same time
    version: 1.0.0  --> 2.0.0
    settings:
    - name: legacyboot
      value: enabled
      unsupported: false  --> true

upgrading from version 1.0.0 to 2.0.0 will lead to the bios setting responsible for legacy boot is deprecated/unsupported, thus it is explicitly marked as unsupported and will not be considered during settings applying.

[stefanhipfel]

How do we apply bios settings/ boot order now?

[aobort]

Boot order: there is a question to discuss in the PR's description, whether we need to keep boot order in Server CR and keep its processing in server-controller, or we'll move it to ServerBIOS. Semantically we should move it to ServerBIOS.

Settings: lines 231-245 in serverbios-controller:

func (r *ServerBIOSReconciler) reconcileSettingsUpdate(
	ctx context.Context,
	log logr.Logger,
	serverBIOS *metalv1alpha1.ServerBIOS,
) (ctrl.Result, error) {
	log.V(1).Info("invoking settings update job")
	jobReference, err := r.createJob(ctx, log, serverBIOS, metalv1alpha1.ApplyBIOSSettingsJobType)
	if err != nil {
		return ctrl.Result{}, err
	}
	return r.patchJobReference(ctx, log, serverBIOS, metalv1alpha1.RunningJobRef{
		Type:   metalv1alpha1.ApplyBIOSSettingsJobType,
		JobRef: jobReference,
	})
}

The job implementation is in progress, hopefully will finish it today and push to PR.