Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout check in discovery state #136

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Add timeout check in discovery state #136

merged 4 commits into from
Oct 7, 2024

Conversation

stefanhipfel
Copy link
Contributor

No description provided.

@stefanhipfel stefanhipfel self-assigned this Sep 25, 2024
@stefanhipfel stefanhipfel marked this pull request as draft September 25, 2024 09:20
@stefanhipfel stefanhipfel linked an issue Sep 25, 2024 that may be closed by this pull request
Handle failed discovery for new Servers #104
Closed
defo89
defo89 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@defo89 defo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@defo89 defo89 added the enhancement New feature or request label Sep 26, 2024
@stefanhipfel stefanhipfel marked this pull request as ready for review September 30, 2024 09:21
@defo89
Copy link
Contributor

defo89 commented Oct 1, 2024

lgtm from me, anything to add from your side @afritzler @hardikdr ?

@afritzler afritzler changed the title adds timeout check in discovery state Add timeout check in discovery state Oct 2, 2024
afritzler
afritzler requested changes Oct 2, 2024
View reviewed changes
cmd/manager/main.go Outdated Show resolved Hide resolved
internal/controller/server_controller_test.go Outdated Show resolved Hide resolved
@afritzler afritzler merged commit 1335d92 into main Oct 7, 2024
8 checks passed
@afritzler afritzler deleted the failed_discovery branch October 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchwarzM SchwarzM SchwarzM left review comments

@defo89 defo89 defo89 approved these changes

@afritzler afritzler afritzler approved these changes

Assignees

@stefanhipfel stefanhipfel

Labels
enhancement New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle failed discovery for new Servers
4 participants
@stefanhipfel @defo89 @afritzler @SchwarzM