Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkfs options parameter to volume context #512

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

sujeet01
Copy link
Contributor

Proposed Changes

This update introduces a new parameter, ParameterMkfsOptions, to the volume context for specifying options for the mkfs command. Key changes include:

  • The new parameter is utilized during the volume stage.
  • The volume format and mount method are modified to process the new format options.
  • The corresponding mock method for testing is updated with the new parameter.
  • The mount method in the NodeStageVolume test was updated from FormatAndMount to FormatAndMountSensitiveWithFormatOptions

This change is borrowed from the GitLab fork of CSI driver, originally authored by @FlorinPeter. Thanks for the contribution!

@sujeet01 sujeet01 requested a review from a team as a code owner September 27, 2024 08:06
@github-actions github-actions bot added enhancement New feature or request size/M labels Sep 27, 2024
@sujeet01 sujeet01 self-assigned this Sep 27, 2024
pkg/driver/node.go Outdated Show resolved Hide resolved
pkg/driver/node.go Outdated Show resolved Hide resolved
@afritzler afritzler merged commit 8017ef7 into main Oct 16, 2024
8 checks passed
@afritzler afritzler deleted the enh/add-mkfs-options branch October 16, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants