Skip to content

Commit

Permalink
Do not update IP on deletion
Browse files Browse the repository at this point in the history
The finalizer has already been removed, so the object is not existing
  • Loading branch information
damyan committed Mar 20, 2024
1 parent d753718 commit 109da33
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions controllers/ip_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@ func (r *IPReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Re
}

controllerutil.RemoveFinalizer(ip, CIPFinalizer)
err := r.Update(ctx, ip)
if err != nil {
log.Error(err, "unable to update ip resource on finalizer removal", "name", req.NamespacedName)
return ctrl.Result{}, err
}
}
return ctrl.Result{}, nil
}
Expand Down

0 comments on commit 109da33

Please sign in to comment.