Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to github.com/gardener/[email protected] #605

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Update to github.com/gardener/[email protected] #605

merged 5 commits into from
Sep 25, 2024

Conversation

kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Aug 13, 2024 •
edited by ushabelgur
Loading

Proposed Changes

  • Update to github.com/gardener/[email protected]
  • Regenerate manifests
  • Replace github.com/gardener/gardener/pkg/utils/kubernetes.Key dependency with sigs.k8s.io/controller-runtime/pkg/client.ObjectKey / sigs.k8s.io/controller-runtime/pkg/client.ObjectKeyFromObject
  • Set ImageVector Environment variable key as OverrideEnv
  • Add default option to set Extension class
  • Modify tests as needed

@kasabe28 kasabe28 self-assigned this Aug 13, 2024
@github-actions github-actions bot added size/XL apis controllers documentation Improvements or additions to documentation labels Aug 13, 2024
@github-actions github-actions bot added size/L and removed size/XL labels Aug 30, 2024
@ushabelgur ushabelgur marked this pull request as ready for review September 20, 2024 08:43
@ushabelgur ushabelgur requested a review from a team as a code owner September 20, 2024 08:43
@ushabelgur ushabelgur self-assigned this Sep 20, 2024
afritzler
afritzler approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kasabe28 and @ushabelgur! Lgtm. Do you think we can merge this for the next upcoming version?

@afritzler afritzler merged commit 52b88c0 into main Sep 25, 2024
7 checks passed
@afritzler afritzler deleted the upgrade-gardener-to-1.101 branch September 25, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@ushabelgur ushabelgur

@kasabe28 kasabe28

Labels
apis controllers documentation Improvements or additions to documentation size/L
Projects
Integration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasabe28 @afritzler @ushabelgur