gRPC protocol change #346
Merged
gRPC protocol change #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlagueCZ
force-pushed
the
feature/grpc_versioning
branch
from
fa526a1
to
3bd6b61
Compare
guvenc
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
As this was already mostly pre-reviewed and the final state also looks good to me. So I will approve it and but dont merge it yet and will do some integration testing with other changed components. (go library and metalnet)
Are the branches ready to be tested on those two projects ?
|
All projects (net-dpservice-go, metalnet, dpservice-cli) are ready to be tested. They all have same branch name: feature/grpc_versioning. |
PlagueCZ
force-pushed
the
feature/grpc_versioning
branch
from
3bd6b61
to
d63a588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the newly introduced versioning of the protocol is a breaking change, I refactored the protocol itself, since there is no backwards compatibility possible anyway.
Most changes are previously discussed. The dpservice-cli golang client exists in a branch of the same name in its repository.
There already is a metalnet branch that uses this protocol via the new golang library.
Of course this it to be merged along with them and only after all three components are approved separately.
Any changes are still possible, so please suggest anything that would be helpful.