-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow VM to talk to a co-locating server via a private load balancer #341
Conversation
cf2c8af
to
a8fd633
Compare
@byteocean |
a8fd633
to
f8cd5f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed and some open questions. Thanks.
f8cd5f4
to
5794f25
Compare
573202e
to
8e1a1c5
Compare
@byteocean I pushed an improved version of the solution in this PR. Conntrack refactoring is ok but the way the traffic is isolated changed a bit. (More similar to the "other" uni-directional flows we have) Please take a look. |
8e1a1c5
to
d261f77
Compare
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
5db9b28
to
5a55108
Compare
Some minor revisions on code comments have been added to be more clear in the code why it is written in this way, otherwise, it is a difficult special case that is hard to digest. A improvement solution on the route instability issue (on-demand, which is different from #344 ) is also provided in this PR, otherwise, this PR cannot work properly. |
@byteocean What about age_ctx storage ? This still seems to be 4 ? Dont we need to increase it as discussed today ? |
5a55108
to
aa9947f
Compare
@guvenc it was put into another branch, but now also fixed in this one |
@byteocean |
aa9947f
to
87e7c4b
Compare
This new commit is removed. The point of having this commit is to make this PR a working one when route change is happening. |
This PR deals with a special communication scenario as depicted in the following figure (thanks to @guvenc). More precisely, due to the complex flow pattern, the connection tracking was not correctly performed and matched for packets. This PR includes two major changes: