Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go toolchain to the go.mod file #320

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

afritzler
Copy link
Member

@afritzler afritzler commented Sep 7, 2023

Proposed Changes

  • Add toolchain go1.21.0 to the go.mod file
  • Fix VolumeClass Quantity to ensure a size bigger than 9Gi

…olves updating dependencies in the `go.mod` file and updating the versions of `github.com/ceph/go-ceph` and `github.com/containerd/containerd`. These updates are considered repo settings and fall under the `chore` category.: update dependencies to latest versions

- Add `toolchain go1.21.0` to the `go.mod` file
- Update the version of `github.com/ceph/go-ceph` to `v0.23.0`
- Update the version of `github.com/containerd/containerd` to `v1.7.3`

Signed-off-by: Andreas Fritzler <[email protected]>
@afritzler afritzler requested a review from a team as a code owner September 7, 2023 12:19
@afritzler afritzler changed the title Add go toolchain in go.mod file Add go toolchain to the go.mod file Sep 7, 2023
- Modify the assertion for `resp.VolumeClassStatus` to check the first element only
- Modify the assertion for `resp.VolumeClassStatus` to check the `VolumeClass` field
- Modify the assertion for `resp.VolumeClassStatus` to check the `Quantity` field

Signed-off-by: Andreas Fritzler <[email protected]>
@github-actions github-actions bot added size/S and removed size/XS labels Sep 7, 2023
@afritzler afritzler merged commit 5062969 into main Sep 7, 2023
9 checks passed
@afritzler afritzler deleted the chore/add-to-toolchain branch September 7, 2023 12:55
lukas016 pushed a commit to opensovereigncloud/ceph-provider that referenced this pull request May 23, 2024
* The best label for this code change would be `chore`. This change involves updating dependencies in the `go.mod` file and updating the versions of `github.com/ceph/go-ceph` and `github.com/containerd/containerd`. These updates are considered repo settings and fall under the `chore` category.: update dependencies to latest versions

- Add `toolchain go1.21.0` to the `go.mod` file
- Update the version of `github.com/ceph/go-ceph` to `v0.23.0`
- Update the version of `github.com/containerd/containerd` to `v1.7.3`

Signed-off-by: Andreas Fritzler <[email protected]>

* test: refactor assertion for resp.VolumeClassStatus field

- Modify the assertion for `resp.VolumeClassStatus` to check the first element only
- Modify the assertion for `resp.VolumeClassStatus` to check the `VolumeClass` field
- Modify the assertion for `resp.VolumeClassStatus` to check the `Quantity` field

Signed-off-by: Andreas Fritzler <[email protected]>

---------

Signed-off-by: Andreas Fritzler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant