Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add httpboot tests #162

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add httpboot tests #162

merged 3 commits into from
Jun 25, 2024

Conversation

damyan
Copy link
Member

@damyan damyan commented Jun 24, 2024

No description provided.

@damyan damyan marked this pull request as draft June 24, 2024 15:50
@github-actions github-actions bot added enhancement New feature or request size/L labels Jun 24, 2024
@damyan damyan force-pushed the feature/add-httpboot-tests branch from 7f2ae6d to ed6d5fb Compare June 24, 2024 15:52
@damyan damyan force-pushed the feature/add-httpboot-tests branch 2 times, most recently from c514198 to fec463c Compare June 25, 2024 08:15
@damyan damyan force-pushed the feature/add-httpboot-tests branch from fec463c to edcb0b7 Compare June 25, 2024 08:37
@damyan
Copy link
Member Author

damyan commented Jun 25, 2024

@5kt @hardikdr
Hi folks, could you please review that one? Apart from implementing some really basic tests for HTTPBOOT plugin (those should be straightforward), I changed some small things along the way in the plugin itself, those might need a closer look. Changes:

  • added some additional check about the boot address protocol, only HTTP and HTTPS are supported (IPv4 and IPv6)
  • removed generic options in favour of specific options - BootFileURL/VendorClass (IPv6)
  • added some more strict check of the HTTPClient string sent by the client, that's slicing vs. string.Contains() (IPv4 + IPv6)
  • mirrored the custom UKI logic for IPv4
  • added some verbose output, might be useful when debugging (IPv4 and IPv6)

Note: client-specific configuration tests are still to come as I make myself familiar with envtest now. Splitting the PR for readability

@damyan damyan marked this pull request as ready for review June 25, 2024 08:39
@damyan damyan enabled auto-merge (squash) June 25, 2024 08:39
@damyan damyan force-pushed the feature/add-httpboot-tests branch from b4a8ff8 to d06f7f7 Compare June 25, 2024 08:52
@damyan damyan requested review from 5kt and hardikdr June 25, 2024 08:53
@damyan damyan merged commit 0369022 into main Jun 25, 2024
8 checks passed
@damyan damyan deleted the feature/add-httpboot-tests branch June 25, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5kt 5kt 5kt approved these changes

@hardikdr hardikdr Awaiting requested review from hardikdr

Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damyan @5kt