Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for new iron version 0.7 with hyper 0.12 and removed limit_reader #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zgtm
Copy link

@zgtm zgtm commented Feb 11, 2019

This PR reflects that irons request body no longer implements the Read trait (due to hyper using futures, now) and uses the helper function iron::request::get_body_contents() instead.

Because of that, the LimitReader trait is no longer of use here. Instead, one should explore the possibility to implement limited reading in iron::request::get_body_contents() instead.

@zgtm zgtm requested a review from phlmn February 11, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant