feat: using Padding instead of Gap in Avatar.

irihitech · Jan 17, 2025 · a366ca6 · a366ca6
1 parent 33bfd67
commit a366ca6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 43 deletions.
diff --git a/demo/Ursa.Demo/Pages/AvatarDemo.axaml b/demo/Ursa.Demo/Pages/AvatarDemo.axaml
@@ -95,8 +95,8 @@
         </StackPanel>
         <StackPanel Orientation="Horizontal" Spacing="8">
             <u:Avatar Content="AS" />
-            <u:Avatar Content="Semi" Gap="4" />
-            <u:Avatar Content="Semi" Gap="10" />
+            <u:Avatar Content="Semi" Padding="4" />
+            <u:Avatar Content="Semi" Padding="10" />
         </StackPanel>
 
     </StackPanel>

diff --git a/src/Ursa.Themes.Semi/Controls/Avatar.axaml b/src/Ursa.Themes.Semi/Controls/Avatar.axaml
@@ -1,22 +1,20 @@
 <ResourceDictionary
     xmlns="https://github.com/avaloniaui"
     xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    xmlns:u="https://irihi.tech/ursa"
-    xmlns:converters="clr-namespace:Ursa.Converters;assembly=Ursa">
+    xmlns:u="https://irihi.tech/ursa">
     <Design.PreviewWith>
         <StackPanel Margin="20" Orientation="Horizontal" Spacing="8">
             <u:Avatar Content="AS" />
-            <u:Avatar Content="Semi" Gap="4" />
-            <u:Avatar Content="Semi" Gap="10" />
+            <u:Avatar Content="Semi" Padding="4" />
+            <u:Avatar Content="Semi" Padding="10" />
         </StackPanel>
     </Design.PreviewWith>
-    <converters:DoubleToThicknessConverter x:Key="DoubleToThicknessConverter" />
     <ControlTheme x:Key="{x:Type u:Avatar}" TargetType="{x:Type u:Avatar}">
         <Setter Property="Foreground" Value="{DynamicResource AvatarForeground}" />
         <Setter Property="Background" Value="{DynamicResource AvatarGreyBackground}" />
         <Setter Property="FontSize" Value="{DynamicResource AvatarMediumFontSize}" />
         <Setter Property="FontWeight" Value="{DynamicResource AvatarFontWeight}" />
-        <Setter Property="Gap" Value="3" />
+        <Setter Property="Padding" Value="3" />
         <Setter Property="Width" Value="{DynamicResource AvatarMediumWidth}" />
         <Setter Property="Height" Value="{Binding $self.Width}" />
         <Setter Property="Cursor" Value="Hand" />
@@ -32,10 +30,9 @@
                             BorderBrush="{TemplateBinding BorderBrush}"
                             BorderThickness="{TemplateBinding BorderThickness}"
                             CornerRadius="{TemplateBinding CornerRadius}"
-                            Background="{TemplateBinding Background}">
-                        </Border>
+                            Background="{TemplateBinding Background}" />
                         <Viewbox
-                            Margin="{TemplateBinding Gap, Converter={StaticResource DoubleToThicknessConverter}}"
+                            Margin="{TemplateBinding Padding}"
                             StretchDirection="DownOnly">
                             <ContentPresenter
                                 Name="PART_ContentPresenter"

diff --git a/src/Ursa/Controls/Avatar/Avatar.cs b/src/Ursa/Controls/Avatar/Avatar.cs
@@ -7,21 +7,12 @@ namespace Ursa.Controls;
 
 public class Avatar : Button
 {
-    public static readonly StyledProperty<double> GapProperty = AvaloniaProperty.Register<Avatar, double>(
-        nameof(Gap));
-
     public static readonly StyledProperty<IImage?> SourceProperty = AvaloniaProperty.Register<Avatar, IImage?>(
         nameof(Source));
 
     public static readonly StyledProperty<object?> HoverMaskProperty = AvaloniaProperty.Register<Avatar, object?>(
         nameof(HoverMask));
 
-    public double Gap
-    {
-        get => GetValue(GapProperty);
-        set => SetValue(GapProperty, value);
-    }
-
     [ExcludeFromCodeCoverage]
     public IImage? Source
     {

diff --git a/src/Ursa/Converters/DoubleToThicknessConverter.cs b/src/Ursa/Converters/DoubleToThicknessConverter.cs