Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guatemala May initial setup #444

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Guatemala May initial setup #444

wants to merge 7 commits into from

Conversation

mm5330
Copy link

@mm5330 mm5330 commented Aug 29, 2024

Initial commit for Guatemala May forecast maproom

@mm5330
Copy link
Author

mm5330 commented Aug 29, 2024 via email

@jturmelle
Copy link
Contributor

OK then, I should probably wait until you test it before I approve...

(
# Static (non-updating) snapshot of
# http://iridl.ldeo.columbia.edu/SOURCES/.NOAA/.NESDIS/.STAR/.VHP/.16km/.VHI
# which is doubly broken: the upstram URL has changed, plus they had a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstram --> upstream, here and wherever you copied it from.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aaron-kaplan , do you know what is left or missing to approve this pull request?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like @jturmelle reviewed this while I was away, so I'll pass the question to him.

I will point out, however, that you're replying to a comment where I pointed out a typo, and the typos still hasn't been fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was the files they were pointing to didn't exist, so they couldn't have tested it yet in development mode. I was waiting for them to state the testing was OK before approving and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants