Xchourio/oromia bad years #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbfmaproom/data-conversion-scripts/oromia/bad-years-v3-3season.py
Outdated
Show resolved
Hide resolved
fbfmaproom/data-conversion-scripts/oromia/bad-years-v3-3season.py
Outdated
Show resolved
Hide resolved
fbfmaproom/data-conversion-scripts/oromia/bad-years-v3-3season.py
Outdated
Show resolved
Hide resolved
fbfmaproom/data-conversion-scripts/oromia/bad-years-v3-3season.py
Outdated
Show resolved
Hide resolved
fbfmaproom/data-conversion-scripts/oromia/bad-years-v3-3season.py
Outdated
Show resolved
Hide resolved
fbfmaproom/data-conversion-scripts/oromia/bad-years-v3-3season.py
Outdated
Show resolved
Hide resolved
|
@xchourio one last change please: rename |
Done! |
aaron-kaplan
approved these changes
Apr 1, 2024
added 17 commits
April 1, 2024 15:50
xchourio
force-pushed
the
xchourio/oromia-bad-years
branch
from
80d21b9
to
3da3515
Compare
|
Is it ok if I merge this branch to master? (I'm already completed the
rebase step)
…On Mon, Apr 1, 2024 at 3:15 PM Aaron Kaplan ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#414 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV37EIBPFMYSLYTISYVBB23Y3GW6LAVCNFSM6AAAAABFJN5WOCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZRHE2DMMJWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: Update southern Oromia OND bad years
Project: AA(FbF)
To achieve this, we need to produce zarr files from a shared CSV file. I've used the script from Madagascar (bad-years-v3.py) as a basis, which uses a file with similar data values (ranks). I've generalized it in such a way that we can use it for any region/country that provides us with a CSV file. The CSV (see bad_years.csv example) file should have a descriptive first line, followed by a column with the year and a column with the values (ranks) for each station (the column name should be the station). I've added validations considering that in the future, this will be handed over to the local parthners who will be executing it.
Does it make sense to ask the FbF group to take care of updating the bad_year file following this format, or is it better to do it ourselves?
zarr file is available in: /data/aaron/fbf-candidate/oromia/bad-years-v3-ond.zarr