Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the saring counter error #3 & bug in iOS 18.1 Safari #6 #4

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

irsyadpage
Copy link
Contributor

Primary Changes

  • Change filteredPantun to saringKeyword as it reflect the user input text / keyword.
  • Create getFilteredPantunList() function to process the pantun list received from server API.
    • If no pantun received from the server, this function return empty array.
    • If user does not provide any saring "keyword", this function return the pantun list without filtering.
    • If saring "keyword" exist, this function will do filtering before return the filtered list.
  • Change pantun.length to pantunListToRender.length to make code consistent as it provide the same result.

Notes

  • The conditional rendering for Kami jumpa {pantunListToRender.length} pantun untuk tema: {nama_tema}. text is kept to allow for future update. We can put the saring "keyword" on the text as the feedback to user input (current feedback only show counter). Else, the conditional rendering can be removed.

Additional Changes:

  • Add key={index} props during pantun rendering to avoid React warning:
    11

Fixed the saring filtering structured
Revert "pantun" in map() and filter() to "p".
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pantunis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 4:34pm

Prevent `<main>` element from overflow the App container
@irsyadpage irsyadpage changed the title Fix the saring counter error Fix the saring counter error #3 & bug in iOS 18.1 Safari #6 Oct 13, 2024
@irsyadpage
Copy link
Contributor Author

Update

I also included the fix for #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant