Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU ukernel lowering config for data-tiled multi_mma, and a simple ukernel. #19504

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

bjacob
Copy link
Contributor

@bjacob bjacob commented Dec 17, 2024

This PR adds the KernelConfig logic to generate a lowering_config selecting a ukernel for multi_mma. In order to be able to test it, this PR also adds a very simple multi_mma ukernel, but it isn't actually exercised yet, other than successfully compiling to bitcode. The compiler logic only cares about the existence of the resulting bitcode file. The actual lowering to ukernel op will come in the next PR.

@bjacob bjacob changed the title GPU ukernel lowering config for data-tiled multi_mma. GPU ukernel lowering config for data-tiled multi_mma, and a simple ukernel. Dec 17, 2024
@bjacob bjacob force-pushed the users/bjacob/ukernel-multi-mma branch 2 times, most recently from 251f99c to 503a4e1 Compare December 17, 2024 17:38
Base automatically changed from users/bjacob/ukernel-tweaks to main December 17, 2024 17:43
Signed-off-by: Benoit Jacob <[email protected]>
@bjacob bjacob force-pushed the users/bjacob/ukernel-multi-mma branch from 503a4e1 to 0aa5194 Compare December 17, 2024 17:44
@bjacob bjacob marked this pull request as ready for review December 17, 2024 17:45
Signed-off-by: Benoit Jacob <[email protected]>
@bjacob bjacob requested a review from kuhar December 17, 2024 19:00
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjacob bjacob merged commit 72d98bc into main Dec 17, 2024
41 of 43 checks passed
@bjacob bjacob deleted the users/bjacob/ukernel-multi-mma branch December 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants