[LinalgExt] Drop the unit dims on scatter ops 2/3 #19450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
changed the title
IanWood1
force-pushed
the
drop_unit_scatter
branch
2 times, most recently
from
ce0ec3a to
cff1fb1
Compare
IanWood1
force-pushed
the
drop_unit_scatter
branch
from
cff1fb1 to
612804e
Compare
IanWood1
changed the title
IanWood1
force-pushed
the
drop_unit_scatter
branch
from
98cf839 to
4a6b874
Compare
IanWood1
requested review from
hanhanW,
MaheshRavishankar and
rsuderman
as code owners
IanWood1
force-pushed
the
drop_unit_scatter
branch
from
4a6b874 to
f0cabbc
Compare
MaheshRavishankar
approved these changes
Jan 6, 2025
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/ReshapeFusion.cpp
Show resolved
Hide resolved
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds patterns to drop the unit dims of a
iree_linalg_ext.scatter's%updatestensor. It only drops the leading unit dimensions from the portion ofupdatesthat represents the indexed dimensions.NOTE: Ignore the first commit. It has a separate PR #19560.See the main issue #19091